ADU E2E tests #266
Merged
ADU E2E tests #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danewalton-msft
force-pushed
the
dane/adu-e2e
branch
from
0bab98a to
58cb770
Compare
danewalton-msft
force-pushed
the
dane/adu-e2e
branch
from
f4ae521 to
fd5608a
Compare
vaavva
reviewed
Oct 21, 2022
| } else { | ||
| var patch = { | ||
| tags: { | ||
| ADUGroup: "linux-e2e-group" |
There was a problem hiding this comment.
If this string is used other places in testing, can it be in a variable?
| @@ -0,0 +1,660 @@ | |||
| // Copyright (c) Microsoft. All rights reserved. | |||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | |||
|
|
|||
There was a problem hiding this comment.
Does the style checker work for files? If it's not something that makes sense to add to the repo, it could be good to quickly run the new files through something to make the semi-colon usage more consistent
vaavva
reviewed
Oct 21, 2022
| /* Copyright (c) Microsoft Corporation. | ||
| * Licensed under the MIT License. */ | ||
|
|
||
| #include <stdarg.h> |
There was a problem hiding this comment.
Not sure why this, the mbedtls port, and tsconfig are showing up as new files instead of renames - might be worth figuring out to maintain the history.
There was a problem hiding this comment.
yea i tried forcing it but seems to keep them as new files and the adu ones as moved
vaavva
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.