Reverting the multi TFM update #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soninaren
force-pushed
the
nasoni/installnet8
branch
from
d16407a to
5648e77
Compare
soninaren
force-pushed
the
nasoni/installnet8
branch
from
c7c728f to
ca74abf
Compare
mattchenderson
requested changes
May 8, 2024
There was a problem hiding this comment.
Change to targets file is missing. See 0528a84#diff-d2a7710deabbac669554a8b567e1f2fc024f252e539b77407314770cc05b9b47L15
fabiocav
reviewed
May 8, 2024
There was a problem hiding this comment.
To make things clear, you want to add the following to your project:
<RollForward>Major</RollForward>This will enable the application to roll to the next major if 6.0 is not present.
For reference: https://learn.microsoft.com/en-us/dotnet/core/versions/selection#control-roll-forward-behavior
mattchenderson
previously requested changes
May 9, 2024
src/Microsoft.NET.Sdk.Functions.MSBuild/Targets/Microsoft.NET.Sdk.Functions.targets
Outdated
Show resolved
Hide resolved
soninaren
force-pushed
the
nasoni/installnet8
branch
from
e12e6ca to
b113999
Compare
soninaren
force-pushed
the
nasoni/installnet8
branch
from
b113999 to
0b3bbe6
Compare
fabiocav
approved these changes
May 9, 2024
| @@ -87,7 +87,7 @@ WARNING: DO NOT MODIFY this file unless you are knowledgeable about MSBuild and | |||
| <Target Name="_InitializeFunctionsSdk"> | |||
| <Warning Text="The ExtensionsMetadataGenerator package was not imported correctly. Are you missing '$(_ExtensionsMetadataGeneratorTargetsPath)' or '$(_ExtensionsMetadataGeneratorPropsPath)'?" | |||
| Condition="!$(AzureFunctionsVersion.StartsWith('v1')) And ('$(_ExtensionsMetadataGeneratorTargetsImported)' == '' Or '$(_ExtensionsMetadataGeneratorPropsImported)' == '')" /> | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.