Enabling multiple TFMs / tooling suffixes #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattchenderson
force-pushed
the
mattchenderson/net8-inproc
branch
5 times, most recently
from
de1630f to
e2f92f9
Compare
mattchenderson
force-pushed
the
mattchenderson/net8-inproc
branch
from
e2f92f9 to
0528a84
Compare
brettsam
reviewed
May 3, 2024
src/Microsoft.NET.Sdk.Functions.MSBuild/Targets/Microsoft.NET.Sdk.Functions.targets
Show resolved
Hide resolved
soninaren
force-pushed
the
mattchenderson/net8-inproc
branch
from
2b83280 to
2a683ea
Compare
soninaren
reviewed
May 7, 2024
src/Microsoft.NET.Sdk.Functions.MSBuild/Targets/Microsoft.NET.Sdk.Functions.targets
Outdated
Show resolved
Hide resolved
mattchenderson
commented
May 7, 2024
src/Microsoft.NET.Sdk.Functions.MSBuild/Targets/Microsoft.NET.Sdk.Functions.targets
Outdated
Show resolved
Hide resolved
src/Microsoft.NET.Sdk.Functions.MSBuild/Targets/Microsoft.NET.Sdk.Functions.targets
Outdated
Show resolved
Hide resolved
soninaren
force-pushed
the
mattchenderson/net8-inproc
branch
from
98c7f8f to
5762af6
Compare
|
Since I'm the original author of the PR, I am unable to approve, but the current state looks good to me. Let's go ahead and get this in. |
Since i am not the original author i can approve. |
soninaren
approved these changes
May 8, 2024
wforney
reviewed
Jul 10, 2024
| @@ -12,7 +12,7 @@ WARNING: DO NOT MODIFY this file unless you are knowledgeable about MSBuild and | |||
| xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
|
|
|||
| <PropertyGroup> | |||
| <_FunctionsTaskFramework>net6.0</_FunctionsTaskFramework> | |||
| <_FunctionsTaskFramework>$(TargetFramework)</_FunctionsTaskFramework> | |||
There was a problem hiding this comment.
I think this is what broke builds later on...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to support .NET 8 builds in the future, in alignment with upcoming tooling feed changes.
This takes inspiration from what's done in the isolated worker mode. However, note that the conditions here are just based on TFM. This will override AzureFunctionsVersion, which should be perfectly fine here.