Skip to content
This repository has been archived by the owner on Jul 19, 2024. It is now read-only.

Introducing function level auto complete for single/batch and sessions #141

Closed
wants to merge 3 commits into from
Closed

Introducing function level auto complete for single/batch and sessions #141

wants to merge 3 commits into from

Conversation

apranaseth
Copy link
Member

@alrod
Copy link
Member

alrod commented Mar 31, 2021

Also we need to validate new setting works with function.json and update docs in https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-service-bus-trigger?tabs=csharp#configuration

alrod
alrod suggested changes Mar 31, 2021
View reviewed changes
src/Microsoft.Azure.WebJobs.Extensions.ServiceBus/Listeners/ServiceBusListener.cs Outdated Show resolved Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.ServiceBus/Listeners/ServiceBusListener.cs Outdated Show resolved Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.ServiceBus/Listeners/ServiceBusListener.cs Outdated Show resolved Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.ServiceBus/ServiceBusTriggerAttribute.cs Show resolved Hide resolved
...ft.Azure.WebJobs.Extensions.ServiceBus/Triggers/ServiceBusTriggerAttributeBindingProvider.cs Outdated Show resolved Hide resolved
...ft.Azure.WebJobs.Extensions.ServiceBus/Triggers/ServiceBusTriggerAttributeBindingProvider.cs Outdated Show resolved Hide resolved
test/Microsoft.Azure.WebJobs.Extensions.ServiceBus.Tests/ServiceBusEndToEndTests.cs Outdated Show resolved Hide resolved
@apranaseth apranaseth force-pushed the apseth-functionleveautocomplete branch from 78c121f to c87a726 Compare April 4, 2021 18:32
@alrod
Copy link
Member

alrod commented Apr 12, 2021

Overall the change looks good to me. The only concerns are tests:

  1. We do not need to test drain mode Drain mode/Sessions in E2E tests with the change. I would add one new E2E test to test that AutoComplete is overwritten.
  2. Add a unit tests for ServiceBusOptions.DeepClone - to make sure all properties are copied.
    • maybe add a unit test for ServiceBusTriggerAttribute.TryCreateAsync/GetServiceBusOptions (or modify existing)- to make sure the overwrite is applied.

@apranaseth apranaseth force-pushed the apseth-functionleveautocomplete branch from c87a726 to 076e9c6 Compare April 13, 2021 16:35
@apranaseth
Copy link
Member Author

I have removed all E2E but one to test it E2E and have added the unit tests.

@apranaseth apranaseth closed this Apr 14, 2021
@apranaseth apranaseth reopened this Apr 14, 2021
@fabiocav fabiocav closed this Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alrod alrod alrod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apranaseth @alrod @fabiocav