fix: code sign validation for setuptools #1570
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For Windows builds, .exe files brought by setuptools didn't have signing certificates. The recommended template for ESRP signing doesn't work with .exe files. However, since setuptools is only brought by pyproject.toml to build the worker, it doesn't need to be brought as a worker dependency. This excludes setuptools from being part of the published worker artifact.
Failing pipeline due to signing (internal only)
Passing pipeline with these changes (internal only)
Fixes #
PR information
Quality of Code and Contribution Guidelines