Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker tests updates #1457

Merged
merged 9 commits into from
Apr 2, 2024
Merged

Docker tests updates #1457

merged 9 commits into from
Apr 2, 2024

Conversation

gavin-aguiar
Copy link
Contributor

@gavin-aguiar gavin-aguiar commented Mar 29, 2024

Description

  • Added a custom image setting for running consumption tests
  • Skipped service bus tests for docker till image is updated
  • Fixed cron jobs for test to avoid conflicts
  • Running setup build for custom docker container tests so that we build protos which would be eventually mounted on the container
  • Changed EventHub batch tests to use blob output instead of table output
  • Table output binding structure changed with latest table extension. Format was dict, now is list. Changed tests to accommodate for this
  • Removed duplicate unit test

 

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.23%. Comparing base (4c8fb7b) to head (4a3f20c).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1457      +/-   ##
==========================================
+ Coverage   85.08%   85.23%   +0.15%     
==========================================
  Files          35       35              
  Lines        1998     1998              
  Branches      378      378              
==========================================
+ Hits         1700     1703       +3     
+ Misses        222      219       -3     
  Partials       76       76              
Flag Coverage Δ
unittests 85.18% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gavin-aguiar gavin-aguiar merged commit 30789ed into dev Apr 2, 2024
49 checks passed
@gavin-aguiar gavin-aguiar deleted the gaaguiar/cns_custom_image branch April 2, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants