Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.6 baggage code removal #1419

Merged
merged 9 commits into from
Feb 13, 2024
Merged

Python 3.6 baggage code removal #1419

merged 9 commits into from
Feb 13, 2024

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented Jan 31, 2024

Description

Fixes # https://github.com/Azure/azure-functions-pyfx-planning/issues/139 // https://github.com/Azure/azure-functions-pyfx-planning/issues/176


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@hallvictoria hallvictoria changed the title Hallvictoria/py36 cleanup Python 3.6 baggage code removal Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5f352af) 85.46% compared to head (ae10d6e) 85.45%.

Files Patch % Lines
azure_functions_worker/main.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1419      +/-   ##
==========================================
- Coverage   85.46%   85.45%   -0.02%     
==========================================
  Files          35       35              
  Lines        1968     1966       -2     
  Branches      370      370              
==========================================
- Hits         1682     1680       -2     
  Misses        213      213              
  Partials       73       73              
Flag Coverage Δ
unittests 85.40% <60.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hallvictoria hallvictoria marked this pull request as ready for review February 1, 2024 18:37
python/prodV2/worker.config.json Outdated Show resolved Hide resolved
pack/Microsoft.Azure.Functions.V3.PythonWorker.nuspec Outdated Show resolved Hide resolved
tests/unittests/test_utilities_dependency.py Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@vrdmr
Copy link
Member

vrdmr commented Feb 1, 2024

We should be able to remove aio_compat.py as well as rethink if we need typing_inspect.py itself.

Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT :shipit:

Take a look at the docker tests as well to ensure it passes.

azure_functions_worker/utils/dependency.py Outdated Show resolved Hide resolved
@hallvictoria hallvictoria merged commit 3dd54af into dev Feb 13, 2024
46 of 51 checks passed
@hallvictoria hallvictoria deleted the hallvictoria/py36-cleanup branch February 13, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants