-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.6 baggage code removal #1419
Conversation
…-worker into hallvictoria/py36-cleanup
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #1419 +/- ##
==========================================
- Coverage 85.46% 85.45% -0.02%
==========================================
Files 35 35
Lines 1968 1966 -2
Branches 370 370
==========================================
- Hits 1682 1680 -2
Misses 213 213
Partials 73 73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We should be able to remove aio_compat.py as well as rethink if we need typing_inspect.py itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
Take a look at the docker tests as well to ensure it passes.
Description
Fixes # https://github.com/Azure/azure-functions-pyfx-planning/issues/139 // https://github.com/Azure/azure-functions-pyfx-planning/issues/176
PR information
Quality of Code and Contribution Guidelines