Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptors to survey in GitHub Discussions #1369

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

shreyabatra4
Copy link
Contributor

This reverts commit c5b6ef0.

Description

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c5b6ef0) 85.40% compared to head (2d20b19) 84.89%.

❗ Current head 2d20b19 differs from pull request most recent head 7f1dfe9. Consider uploading reports for the commit 7f1dfe9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1369      +/-   ##
==========================================
- Coverage   85.40%   84.89%   -0.52%     
==========================================
  Files          35       35              
  Lines        1953     1953              
  Branches      285      370      +85     
==========================================
- Hits         1668     1658      -10     
- Misses        214      220       +6     
- Partials       71       75       +4     
Flag Coverage Δ
unittests 84.84% <ø> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shreyabatra4 shreyabatra4 changed the title Revert "syntax changes (#1368)" Add descriptors to survey in GitHub Discussions Nov 22, 2023
@shreyabatra4 shreyabatra4 merged commit 9df8932 into dev Nov 22, 2023
@shreyabatra4 shreyabatra4 deleted the revert-1368-shbatr/survey-discussions branch November 22, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant