Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook for logs #739

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Add hook for logs #739

merged 2 commits into from
Apr 11, 2024

Conversation

ejizba
Copy link
Contributor

@ejizba ejizba commented Apr 11, 2024

This PR provides a clean way to perform an operation every time the worker sends a log. The motivation behind this is to send each log to open telemetry (tracked by Azure/azure-functions-nodejs-library#245). Most of the otel support will be in a separate library, and I have a working prototype I can demo offline, but nothing ready for a legit PR yet. The library can be finalized at a later date, but I want to get these worker changes in so they can start rolling out.

There is a workaround available to the library today meaning these changes aren't strictly necessary, but it has two drawbacks:

  1. It's ugly (as described here)
  2. It only lets you access user logs and this new hook lets you access both user and system logs

@ejizba ejizba requested a review from castrodd April 11, 2024 02:43
@ejizba ejizba merged commit bccdce3 into v3.x Apr 11, 2024
15 checks passed
@ejizba ejizba deleted the ej/otel branch April 11, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants