Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple workers with new indexing #641

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Conversation

ejizba
Copy link
Contributor

@ejizba ejizba commented Oct 20, 2022

Related to #638

This PR does a few things:

  1. Always include worker id when logging that we received a request. This makes debugging the "multiple worker" scenario so much easier
  2. Use function name as function id instead of a random guid. This ensures each worker returns the same thing
  3. Allow the library package to specify both the name and id. This just gives us more flexibility to fix things on the library-side instead of worker-side if necessary down the line
  4. Adjust the worker indexing booleans on WorkerChannel for two reasons:
    a. To account for the fact that only the 1st worker gets the FunctionsMetadataRequest
    b. To more explicitly separate the worker-indexing and legacy scenarios and avoid any mingling

@ejizba ejizba merged commit 1455af9 into v3.x Oct 31, 2022
@ejizba ejizba deleted the ej/multiWorkersV2 branch October 31, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants