Adding package.json warning when using AzureFiles #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
ejizba
reviewed
Dec 16, 2021
src/WorkerChannel.ts
Outdated
| delayInMs = 5000; | ||
| } | ||
| setTimeout(() => { | ||
| const path = require('path'); |
There was a problem hiding this comment.
nit: I would put this "path" import at the top of the file with all the other imports
| this.log({ | ||
| message: | ||
| 'package.json is not found at the root of the Function App in Azure Files - cold start for NodeJs can be affected.', | ||
| level: LogLevel.Debug, |
There was a problem hiding this comment.
Should this be LogLevel.Warning?
There was a problem hiding this comment.
Let's leave it as LogLevel. Debug as we do not want to scary customers with sudden unknown warning.
src/WorkerChannel.ts
Outdated
| @@ -167,6 +168,8 @@ export class WorkerChannel implements IWorkerChannel { | |||
| err = exception; | |||
| } | |||
|
|
|||
| this.logColdStartWarning(); | |||
There was a problem hiding this comment.
I believe by putting this in functionLoadRequest, the log will get written once per function. However, we really only need to log it once per app. With that in mind, I think workerInitRequest might be a better place
There was a problem hiding this comment.
yeah, you are right. moved to workerInitRequest
ejizba
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On reading function code NodeJs tries to find 'package.json' all the way up to the file system root
In Azure files it causes a delay during cold start as connection to Azure Files is an expensive operation.
We want to add a log to detect the issue.