Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset all app data on WorkerChannel during env reload #670

Closed
ejizba opened this issue Mar 21, 2023 · 0 comments · Fixed by #680
Closed

Reset all app data on WorkerChannel during env reload #670

ejizba opened this issue Mar 21, 2023 · 0 comments · Fixed by #680

Comments

@ejizba
Copy link
Contributor

ejizba commented Mar 21, 2023

For placeholders, we're currently relying on the fact that the default dummy app is not a Node.js app (I think it's a csx app). Theoretically if the dummy app was a Node.js app (especially a v4 app), some of its data (like hooks, registered functions, etc.) could bleed over into the real customer's app after a func env reload.

We should consider a clean reset of all app-related data just to be safe. Also if we reset all app-related data, we don't have to worry about forgetting to reset a random boolean like in #669.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant