New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register function fails on placeholders when indexing is on by default #669

Closed

ejizba opened this issue Mar 21, 2023 · 0 comments · Fixed by #671

Labels

bug P1

Milestone

Contributor

ejizba commented Mar 21, 2023

Here's what happens:

Host starts worker in placeholder mode (aka with a dummy app)
Host asks worker to index. Worker finds nothing to index in the dummy app and sets an internal boolean basically saying "indexing done"
Host sends reload request with customer's actual app
Worker reloads, but fails to load the user's app with error "A function can only be registered during app startup." because our internal boolean said we already indexed

NOTE: This is only a problem if indexing is on by default because step 2 would be skipped if it's off by default.

ghost added the Needs: Triage (Functions) label

ejizba added bug P1 and removed Needs: Triage (Functions) labels

ejizba mentioned this issue

Reset all app data on WorkerChannel during env reload #670

Closed

ejizba added this to the March 2023 milestone

ejizba mentioned this issue

Fix registerFunction for placeholders when indexing is on by default #671

Merged

ejizba closed this as completed in #671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment