Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to 1es pipelines #265

Merged
merged 3 commits into from
May 31, 2024
Merged

Switch to 1es pipelines #265

merged 3 commits into from
May 31, 2024

Conversation

ejizba
Copy link
Contributor

@ejizba ejizba commented May 30, 2024

Official build:
https://azfunc.visualstudio.com/internal/_build/results?buildId=167473&view=results

Public build:
https://dev.azure.com/azfunc/public/_build/results?buildId=167470&view=results

Some notes:

  • Unit tests are run for both, however I'm only testing on windows and linux, not mac. AFAIK our pools don't support mac and linux should be good enough to cover mac
  • Build that creates the tgz drop artifact is run for both, but only official can uncheck "IsPrerelease"
  • I removed most of the sbom logic in favor of the default sbom logic included with 1es. Also, we used to be including the sbom manifest in the tgz artifact, but 1es doesn't do that and turns out we didn't need to either (docs here)

@ejizba ejizba requested a review from castrodd May 30, 2024 23:41
and reference from both official and public
@ejizba ejizba merged commit f5ddd07 into v4.x May 31, 2024
3 checks passed
@ejizba ejizba deleted the ej/1es branch May 31, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants