Switch to eslint-based import sorting #188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this discussion, I wanted to switch off of VS Code's organize imports feature and onto an eslint-based one. I split this PR into two commits for easier review: one to configure eslint and one to auto-fix the repo based on the new config.
Background (feel free to ignore if not interested)
I believe VS Code is using a built-in feature of TypeScript's language service that sorts imports (not an eslint rule). I can't find the feature documented by TypeScript, but it was announced here.
Turns out there are a ton of ways to do this 😅. These are the options I considered:
I liked option 4 the best. "auto-fix" is a priority for me on this and they knocked it out of the park. I followed their example config and made one tweak to remove whitespace between groups.