Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v4 support for specifying retry policy #106

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Add v4 support for specifying retry policy #106

merged 2 commits into from
Sep 8, 2023

Conversation

ejizba
Copy link
Contributor

@ejizba ejizba commented Jun 21, 2023

This doc was particularly helpful as I was working on this feature: https://learn.microsoft.com/azure/azure-functions/functions-bindings-error-pages

Depends on Azure/azure-functions-nodejs-worker#696

Fixes #73

@ejizba ejizba requested a review from hossam-nasr June 21, 2023 23:26
@gunzip
Copy link

gunzip commented Jun 30, 2023

Since the retry policies will work only with kafka, timer and eventhub triggers I wonder if there's a way to extend only these specific options (shouldn't we?) in order to avoid to let users specify retry options for triggers where they won't work.

@ejizba
Copy link
Contributor Author

ejizba commented Jun 30, 2023

Hi @gunzip, I've already done that in this PR. I also have it as an option for Cosmos DB, per the docs I mentioned above. That being said, we don't want the Node.js model to be in charge of blocking people for things like this (I'm not sure when the other triggers will stop working), so I also added it to the generic options so that people can workaround us if they want to.

@ejizba
Copy link
Contributor Author

ejizba commented Aug 9, 2023

ping @hossam-nasr

types/generic.d.ts Show resolved Hide resolved
types/index.d.ts Outdated Show resolved Hide resolved
src/app.ts Show resolved Hide resolved
src/converters/toRpcDuration.ts Show resolved Hide resolved
types/index.d.ts Outdated Show resolved Hide resolved
@ejizba ejizba merged commit c426505 into v4.x Sep 8, 2023
@ejizba ejizba deleted the ej/retry branch September 8, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants