Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and refactor generator for p2p ref and tools #10648

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

jviau
Copy link
Contributor

@jviau jviau commented Nov 21, 2024

Issue describing the changes in this PR

resolves #10651

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Ever since moving to common artifact outputs, ExtensionsMetadataGenerator has been incorrectly packing itself due to hardcoding the output path format. This PR addresses that and performs further refactoring.

  1. Assembly inclusion in the package is now done by calling into an inner-build target from the outer-build to collect all files for that TFM
  2. ExtensionsMetadataGenerator.Console is now referenced via a ProjectReference, correctly establishing restore & build ordering.

@jviau jviau requested a review from a team as a code owner November 21, 2024 22:56
@fabiocav fabiocav self-requested a review November 22, 2024 06:50
@jviau
Copy link
Contributor Author

jviau commented Nov 25, 2024

/azp run host.public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jviau
Copy link
Contributor Author

jviau commented Nov 25, 2024

/azp run host.integration-tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jviau jviau added the area: engineering Engineering improvements label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: engineering Engineering improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExtensionMetadataGenerator is not packaging runtime assemblies
1 participant