Support repeatedly calling WhenAny on a progressively smaller list of already scheduled tasks #446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #349
Today, we following orchestrator code throws an exception.
This exception comes from the incorrect assumption that given list of sub-tasks will not be
yield
'ed multiple times on different parent tasks. In this case, we have twoWhenAny
tasks that both operate on a shared subset of thepending_tasks
list.This PR addresses this by ensuring that the second WhenAny only schedules new actions for the set of sub-tasks that have not been already scheduled. Put more simply: we keep track of whether or not an action for a given task was already generated and, if so, we ignore it future attempts at scheduling it.