[DEPRECATED PR] Create Timer Implementation #39
Conversation
test initial call test get activity and build of task set
add missing bits in task_all to account for a failed task
Get rid of all of those hardcoded property value references
refactor the classes that are parsing json strings to remove all of the hardcoded property names also allows for the classes dangle additional attributes that may be present but not explicitly used for construction
cause it's really hard to read
more concise/readable
causing parsing warnings
have this dependency injected instead of built within
…sing taskset to task_any as args
unneeded layer of abstraction with a DUCK typing language like Python
| @@ -67,6 +68,15 @@ def from_json(cls, json_string): | |||
| """ | |||
| json_dict = json.loads(json_string) | |||
| return cls(**json_dict) | |||
|
|
|||
| def get_input(input: Any) -> Any: | |||
There was a problem hiding this comment.
Looks like you're missing the lambda expression that pulls the input value out of the context string passed in. Also I've been separating the implementation of the functions from the context. Two reasons, 1. the functions aren't dependent on any of the class state, you'll get all sorts of squiggly lines all over this function in PyCharm wanting you to either mark it as a classmethod, or pull it out of the class. 2. separation of concerns, this functions can be tested without the DurableOrchestrationContext object created. This it is a small function all together, but I'd rather stick with the convention of separation. Helps the reader to know that they can look in the tasks package to see the actual implementation of all of the functions, instead of some in the tasks package, some directly implemented in the DurableOrchestrationContext module.
|
Just checked and seems like it's all good in terms of rebasing :) |
priyaananthasankar
changed the title
|
Covered as part of #35 . Closing this PR |
Implements CreateTimer API, TimerTask, CreateTimerAction
TODO: