Allow try-catching Entity exceptions in orchestrators #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnorMcMahon
approved these changes
Sep 24, 2021
tests/orchestrator/test_entity.py
Outdated
| entityId = df.EntityId("Counter", "myCounter") | ||
| try: | ||
| yield context.call_entity(entityId, "add", 3) | ||
| return "Failure" |
There was a problem hiding this comment.
Personally, it is a bit confusing to have the "not exception thrown" path return "failure" and the exception thrown path return "Success". I understand that this is because these test cases are trying to prove that an exception is thrown, but it may be more clear to just change the strings to "No exception thrown" and "Exception thrown".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were recently notified that entity exceptions were not try-catch'able in orchestrator code. The reason for this was that we didn't really have logic to differentiate between a successful and an error'ing entity. This PR fixes this by correctly de-serializing entity exceptions and re-throwing them in the replay.
Tests were also added to prevent future regressions in this area.