Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timer interface to Tasks #323

Merged
merged 11 commits into from
Sep 24, 2021
Merged

Add timer interface to Tasks #323

merged 11 commits into from
Sep 24, 2021

Conversation

davidmrdavid
Copy link
Collaborator

Addresses: #322

It seems that with our most recent refactor, we accidentally removed a few of the timer-specific methods to timer-tasks. This PR adds them back in and includes a test to make sure we don't break this functionality in the future.

Copy link

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidmrdavid davidmrdavid merged commit 1aac4bc into dev Sep 24, 2021
@davidmrdavid davidmrdavid deleted the dajusto/add-timer-interface branch September 24, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants