Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create links for sample folder #219

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Create links for sample folder #219

merged 2 commits into from
Nov 19, 2020

Conversation

kemurayama
Copy link
Contributor

While I was setting up local development environment, I found the brackets that looks links.

It looked the brackets []() are hyper-link
@davidmrdavid
Copy link
Collaborator

Thanks, this was indeed an oversight on our end. I'll look to merging this once the CI passes. I think we've been having some CI issues lately, so I'll have to investigate what's going on with it

@davidmrdavid
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@davidmrdavid davidmrdavid self-requested a review November 11, 2020 17:30
Copy link
Collaborator

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kemurayama
Copy link
Contributor Author

@davidmrdavid , Thanks for approving ! What do I need to do next ?

@kemurayama
Copy link
Contributor Author

Hi @davidmrdavid , would you merge this pull request ?
I found I don't have write access to this repo, so I can't merge this PR by myself.

@davidmrdavid davidmrdavid merged commit 0f8679b into Azure:dev Nov 19, 2020
@davidmrdavid
Copy link
Collaborator

Done! So sorry we kept you waiting @kemurayama. Thank you for your contribution!!

@kemurayama
Copy link
Contributor Author

@davidmrdavid Thank you !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants