No JSON response format validation in PurgeHistory Ops #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought about how to unit test this fix but, since we're fixing the usage of an external API flag, it strikes me as an awkward thing to do; especially considering that this change does not really change any logic on our end, it's just a decoding fix. Our unit testing framework does include some utilities to test this, found here but I figured it may be best to include those as part of another, non-blocking, task. What do y'all think? |
|
Personally, I think it's fine to take on the larger testing work item separately from this PR. |
|
Sounds good, task is here: #191 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #183
We've consistently had issues with
aioHttp, which tries to validate the format of durable-extension and function-host messages, resulting in exceptions. We got hit by the same issue yet again in ticket listed above. I believe this should be the last instance of this sneaky bug.