Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type refactor for runtimeStatus #187

Merged
merged 3 commits into from
Sep 11, 2020
Merged

Type refactor for runtimeStatus #187

merged 3 commits into from
Sep 11, 2020

Conversation

davidmrdavid
Copy link
Collaborator

Addresses: #178

Before, our runtimeStatus variable was allowed to hold any string value, or None. Now, we restrict its possible values by an Enum, giving us finer grained control of its values. Small PR

ConnorMcMahon
ConnorMcMahon reviewed Sep 9, 2020
View reviewed changes
Copy link

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's mostly solid, but I have some questions. May have to do with my lack of knowledge of Python enums and how they are used in the code base.

azure/durable_functions/models/DurableOrchestrationStatus.py Show resolved Hide resolved
tests/models/test_DurableOrchestrationClient.py Show resolved Hide resolved
ConnorMcMahon
ConnorMcMahon approved these changes Sep 11, 2020
View reviewed changes
Copy link

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidmrdavid davidmrdavid merged commit a640ad1 into dev Sep 11, 2020
@davidmrdavid davidmrdavid deleted the dajusto/runtimeStatusTyping branch September 11, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorMcMahon ConnorMcMahon ConnorMcMahon approved these changes

@cgillum cgillum Awaiting requested review from cgillum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidmrdavid @ConnorMcMahon