Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateHttpManagementPayload #162

Merged
merged 5 commits into from
Jul 24, 2020
Merged

Conversation

davidmrdavid
Copy link
Collaborator

@davidmrdavid davidmrdavid commented Jul 15, 2020

Addresses: #161

This PR implements the create_http_management_payload functionality. All the pieces were already implemented as they were necessarily for create_check_status_response. This simply re-arranges them in the way required to create the HttpManagementPayload object.

@davidmrdavid davidmrdavid changed the title WIP: CreateHttpManagementPayload CreateHttpManagementPayload Jul 17, 2020
Copy link

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, just unsure of difference between type hints in code vs documentation.

@davidmrdavid davidmrdavid merged commit 4d709be into dev Jul 24, 2020
@davidmrdavid davidmrdavid deleted the dajusto/create_http_management_payload branch July 24, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants