Improve exception handling in .NET isolated #3034
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Serialize exception details in worker middleware - Attempt to deserialize in host middleware - Ensure inner exceptions + complex messages are preserved
andystaples
changed the title
cgillum
reviewed
Feb 6, 2025
|
|
||
| var orchestrationDetails = await DurableHelpers.GetRunningOrchestrationDetailsAsync(statusQueryGetUri); | ||
| Assert.StartsWith("Microsoft.DurableTask.TaskFailedException", orchestrationDetails.Output); | ||
| Assert.Contains("This activity failed", orchestrationDetails.Output); |
There was a problem hiding this comment.
Is there anything more we can validate here? For example, the type of the inner exception?
|
|
||
| public override string? StackTrace => this.FromException.StackTrace; | ||
|
|
||
| private static TaskFailureDetails? ExceptionToTaskFailureDetailsRecursive(Exception? fromException) |
There was a problem hiding this comment.
Do we have a shared version of this we can use? Or is it in some inaccessible place, so we have to copy it? I'm a tiny bit worried about keeping multiple copies up-to-date if we decide to add richer information to TaskFailureDetails (which is very likely).
There was a problem hiding this comment.
Moved to a new TaskFailureDetailsConverter
Comment on lines
+130
to
+133
| catch (Exception ex) | ||
| { | ||
| throw new DurableSerializationException(ex); | ||
| } |
There was a problem hiding this comment.
Would it be beneficial to catch and do this for orchestration and entity triggers as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves exception handling in .NET isolated by serializing the exception details in the worker middleware, then deserializing them back in host middleware.
This may introduce breaking changes to the way that the Functions Host logs exceptions from Durable activities.
Also adds testing for error handling, activity retry, and activity timeout scenarios in dotnet-isolated
Resolves #2711
Pull request checklist
pending_docs.mdrelease_notes.md/src/Worker.Extensions.DurableTask/AssemblyInfo.csdevandmainbranches and will not be merged into thev2.xbranch.