Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AspNetCore.Http 2.1.x track on netstandard2.0 #2417

Draft
wants to merge 2 commits into
base: v2.x
Choose a base branch
from
Draft

Use AspNetCore.Http 2.1.x track on netstandard2.0 #2417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e67215
use AspNetCore 2.1.x track on netstandard2.0
davidmrdavid Mar 8, 2023
9d3ab5c
remove preview suffix from git accident
davidmrdavid Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/WebJobs.Extensions.DurableTask/LocalHttpListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,7 @@ public async Task StartAsync()
{
this.InternalRpcUri = new Uri($"http://127.0.0.1:{listeningPort}/durabletask/");
var listenUri = new Uri(this.InternalRpcUri.GetLeftPart(UriPartial.Authority));
this.localWebHost = new WebHostBuilder()
.UseKestrel()
.ConfigureKestrel(o =>
this.localWebHost = new WebHostBuilder().UseKestrel(o =>
{
// remove request's Content size limits
o.Limits.MaxRequestBodySize = null;
Expand Down
11 changes: 8 additions & 3 deletions src/WebJobs.Extensions.DurableTask/WebJobs.Extensions.DurableTask.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,14 @@
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
<PackageReference Include="Azure.Identity" Version="1.5.0" />
<PackageReference Include="Microsoft.Azure.WebJobs" Version="3.0.31" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.WebApiCompatShim" Version="2.2.0" />
<PackageReference Include="Microsoft.AspNetCore.Routing" Version="2.2.0" />
<PackageReference Include="Microsoft.AspNetCore.Server.Kestrel" Version="2.2.0" />

<!-- Use 2.1.x track of these AspNetCore packages because 2.2.x track is affected by CVE-2020-1045.
This CVE may be ignored when .NET Core 3.1 or higher is used.-->
<PackageReference Include="Microsoft.AspNetCore.Mvc.WebApiCompatShim" Version="2.1.3" />
<PackageReference Include="Microsoft.AspNetCore.Routing" Version="2.1.1" />
<PackageReference Include="Microsoft.AspNetCore.Server.Kestrel" Version="2.1.3" />
<PackageReference Include="Microsoft.AspNetCore.Http" Version="2.1.34" />

<PackageReference Include="Microsoft.Extensions.Azure" Version="1.1.1" />
<PackageReference Include="Microsoft.Extensions.Http" Version="2.2.0" />
<PackageReference Include="Microsoft.ApplicationInsights" Version="2.12.2" />
Expand Down