[Enhanced Http] Resolve proxying port on worker side #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satvu
commented
Apr 11, 2023
|
|
||
| namespace Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCore | ||
| { | ||
| internal static class HttpUriProvider |
There was a problem hiding this comment.
Temporary - this is needed since the two locations that use it (worker and host builder extensions) both need access to it. Will likely be removed when the extensions issue (we want just one extension call) is resolved.
This reverts commit 4ada7e2.
brettsam
approved these changes
Apr 13, 2023
fabiocav
pushed a commit
that referenced
this pull request
May 5, 2023
fabiocav
pushed a commit
that referenced
this pull request
Jun 19, 2023
fabiocav
pushed a commit
that referenced
this pull request
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #1419. Includes refactoring for handling
IActionResult. SampleAppProgram.cscode set to enhanced-http sample for development.Pull request checklist
release_notes.mdAdditional information
Additional PR information