-
Notifications
You must be signed in to change notification settings - Fork 190
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor CosmosDBConverter to remove use reflection (#1924)
Co-authored-by: Jacob Viau <[email protected]>
- Loading branch information
1 parent
7bba67b
commit 3013ff0
Showing
13 changed files
with
600 additions
and
137 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
114 changes: 114 additions & 0 deletions
114
extensions/Worker.Extensions.Shared/Reflection/ParameterBinder.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
|
|
||
| using System; | ||
| using System.Collections; | ||
| using System.Collections.Generic; | ||
| using System.Reflection; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace Microsoft.Azure.Functions.Worker.Extensions | ||
| { | ||
| /// <summary> | ||
| /// Helpers for performing parameter binding. | ||
| /// </summary> | ||
| internal static class ParameterBinder | ||
| { | ||
| private const BindingFlags DeclaredOnlyLookup = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.Static | BindingFlags.DeclaredOnly; | ||
|
|
||
| /// <summary> | ||
| /// Binds to a collection type. | ||
| /// </summary> | ||
| /// <param name="factory">Factory for producing an enumerable given the element type.</param> | ||
| /// <param name="collectionType">The collection type to bind to.</param> | ||
| /// <returns>The instantiated and populated collection.</returns> | ||
| public static async Task<object> BindCollectionAsync(Func<Type, IAsyncEnumerable<object>> factory, Type collectionType) | ||
| { | ||
| if (factory is null) | ||
| { | ||
| throw new ArgumentNullException(nameof(factory)); | ||
| } | ||
|
|
||
| if (collectionType is null) | ||
| { | ||
| throw new ArgumentNullException(nameof(collectionType)); | ||
| } | ||
|
|
||
| if (!collectionType.TryGetCollectionElementType(out Type? elementType)) | ||
| { | ||
| throw new ArgumentException($"Type '{collectionType}' is not a collection type.", nameof(collectionType)); | ||
| } | ||
|
|
||
| object? collection = null; | ||
| if (collectionType.IsConcreteType() && !collectionType.IsArray) | ||
| { | ||
| collection = Activator.CreateInstance(collectionType)!; | ||
| } | ||
| else if (IsListInterface(collectionType)) | ||
| { | ||
| collection = Activator.CreateInstance(typeof(List<>).MakeGenericType(elementType!))!; | ||
| } | ||
| else if (collectionType.IsArray) | ||
| { | ||
| collection = Activator.CreateInstance(typeof(List<>).MakeGenericType(elementType!))!; | ||
| await BindCollectionAsync(factory(elementType!), collection); | ||
| IList list = (IList)collection; | ||
| Array arrayResult = Array.CreateInstance(elementType!, list.Count); | ||
| list.CopyTo(arrayResult, 0); | ||
| return arrayResult; | ||
| } | ||
| else | ||
| { | ||
| throw new ArgumentException($"Collection type '{collectionType}' is not supported for parameter binding.", nameof(collectionType)); | ||
| } | ||
|
|
||
| await BindCollectionAsync(factory(elementType!), collection); | ||
| return collection; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Binds to a collection. | ||
| /// </summary> | ||
| /// <param name="pageable">The pageable containing the items to populate the collection with.</param> | ||
| /// <param name="collection">The collection to populate.</param> | ||
| /// <returns>A task that completes when the collection has been populated.</returns> | ||
| public static async Task BindCollectionAsync(IAsyncEnumerable<object> pageable, object collection) | ||
| { | ||
| if (pageable is null) | ||
| { | ||
| throw new ArgumentNullException(nameof(pageable)); | ||
| } | ||
|
|
||
| if (collection is null) | ||
| { | ||
| throw new ArgumentNullException(nameof(collection)); | ||
| } | ||
|
|
||
| Action<object> add = GetAddMethod(collection); | ||
| await foreach (object item in pageable) | ||
| { | ||
| add(item); | ||
| } | ||
| } | ||
|
|
||
| private static bool IsListInterface(Type type) | ||
| { | ||
| return type.IsGenericType && | ||
| (type.GetGenericTypeDefinition() == typeof(IList<>) | ||
| || type.GetGenericTypeDefinition() == typeof(ICollection<>) | ||
| || type.GetGenericTypeDefinition() == typeof(IEnumerable<>)); | ||
| } | ||
|
|
||
| private static Action<object> GetAddMethod(object collection) | ||
| { | ||
| if (collection is IList list) | ||
| { | ||
| return e => list.Add(e); | ||
| } | ||
|
|
||
| MethodInfo method = collection.GetType().GetMethod("Add", DeclaredOnlyLookup) | ||
| ?? throw new InvalidOperationException($"Could not find an 'Add' method on collection type '{collection.GetType()}'."); | ||
| return e => method.Invoke(collection, new[] { e }); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.