Fixing in-proc pipeline #4250
Open
Fixing in-proc pipeline #4250
+64
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surgupta-msft
approved these changes
Feb 5, 2025
| @@ -59,7 +59,7 @@ if (-Not $hostVersion) { | |||
|
|
|||
| function getHostFileContent([string]$filePath) { | |||
| $uri = "https://raw.githubusercontent.com/Azure/azure-functions-host/v$hostVersion/$filePath" | |||
| return removeBomIfExists((Invoke-WebRequest -Uri $uri -MaximumRetryCount 5 -RetryIntervalSec 2).Content) | |||
| return removeBomIfExists((Invoke-WebRequest -Uri $uri).Content) | |||
There was a problem hiding this comment.
Curious to know why are we changing this? Main branch still has this -
| @@ -96,9 +96,6 @@ jobs: | |||
| TELEMETRY_INSTRUMENTATION_KEY: $(TELEMETRY_INSTRUMENTATION_KEY) | |||
| IntegrationBuildNumber: $(INTEGRATIONBUILDNUMBER) | |||
| displayName: 'Executing build script' | |||
| - pwsh: | | |||
| .\check-vulnerabilities.ps1 | |||
| displayName: "Check for security vulnerabilities" | |||
There was a problem hiding this comment.
Are we planning to add this back later on?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
The in-proc builds for the core tools pipeline breaks, due to the architecture of the build not being specified like how it is for the main branch. This PR also addresses the CVE for DotnetZip which will be addressed by Brett's PR here
Pull request checklist