Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorging the folder structure #453

Merged
merged 4 commits into from
Jul 25, 2019
Merged

Reorging the folder structure #453

merged 4 commits into from
Jul 25, 2019

Conversation

ShubhaVijayasarathy
Copy link
Contributor

No description provided.

@serkantkaraca
Copy link
Member

Microsoft Visual Studio Solution File, Format Version 12.00

Won't we have 'WindowsAzure.ServiceBus' folder?


Refers to: samples/DotNet/Microsoft.Azure.EventHubs/AnomalyDetector/AnomalyDetector.sln:2 in 225db71. [](commit_id = 225db71, deletion_comment = False)

@serkantkaraca
Copy link
Member

Microsoft Visual Studio Solution File, Format Version 12.00

How would you like to handle ServiceFabricProcessor sample? That has its own package though.


Refers to: samples/DotNet/Microsoft.Azure.EventHubs/AnomalyDetector/AnomalyDetector.sln:2 in 225db71. [](commit_id = 225db71, deletion_comment = False)

@serkantkaraca
Copy link
Member

This sample is on legacy SDK.


Refers to: samples/DotNet/Microsoft.Azure.EventHubs/Rbac/EventHubsSenderReceiverRbac/App.config:1 in 225db71. [](commit_id = 225db71, deletion_comment = False)

@serkantkaraca
Copy link
Member

<Reference Include="Microsoft.ServiceBus, Version=6.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">

This sample is on legacy SDK


Refers to: samples/DotNet/Microsoft.Azure.EventHubs/Rbac/ControlAndDataPlane/ControlAndDataPlane.csproj:51 in 225db71. [](commit_id = 225db71, deletion_comment = False)

@serkantkaraca
Copy link
Member

</system.serviceModel>

Can you remove this section? It still talks in legacy SDK.


Refers to: samples/DotNet/Microsoft.Azure.EventHubs/Rbac/AzureEventHubsSDK/App.config:72 in 225db71. [](commit_id = 225db71, deletion_comment = False)

@serkantkaraca serkantkaraca self-requested a review July 25, 2019 20:55
@serkantkaraca serkantkaraca merged commit a9876ef into master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants