This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
Only set message_id when provided by caller #169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When sending events using the Node.js Event Hubs SDK, it automatically adds the
message_id
property if one is not specified. This is not the same as the behavior in the .NET SDK and leads to some inconsistency in the received messages sent by the various SDKs.This PR removes the default ids from the sent messages and updates the unit tests to check both variations to ensure that the id is set correctly. It also tweaks the relevant tests to receive from an offset rather than a time to make them more reliable.