Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Only set message_id when provided by caller #169

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

princjef
Copy link
Member

Description

When sending events using the Node.js Event Hubs SDK, it automatically adds the message_id property if one is not specified. This is not the same as the behavior in the .NET SDK and leads to some inconsistency in the received messages sent by the various SDKs.

This PR removes the default ids from the sent messages and updates the unit tests to check both variations to ensure that the id is set correctly. It also tweaks the relevant tests to receive from an offset rather than a time to make them more reliable.

@amarzavery
Copy link
Collaborator

✅ Validation status: passed

File Status Preview URL Details
client/lib/eventData.ts ✅Succeeded
client/lib/eventHubSender.ts ✅Succeeded
client/tests/misc.spec.ts ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@amarzavery amarzavery merged commit c677dba into Azure:master Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants