Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting lease duration more than 60 seconds #397

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

vishwas-neo
Copy link

@vishwas-neo vishwas-neo commented May 27, 2019

Taking infinite lease if lease duration is greater then 60 seconds. Renew lease won't be done in case lease duration is greater than 60 sec. Lease will be considered expired if it is not modified for time more than lease duration. For stealing, lease is broken for 3 seconds and acquired again

Description

Issue: https://github.com/Azure/azure-event-hubs-dotnet/issues/394

This checklist is used to make sure that common guidelines for a pull request are followed.

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).
  • If applicable, the public code is properly documented.
  • Pull request includes test coverage for the included changes.
  • The code builds without any errors.

…enew lease won't be done in case lease duration is greater than 60 sec. Lease will be considered expired if it is not modified for time more than leaseduration. For stealing, lease is broken for 3 seconds and acquired again
@serkantkaraca
Copy link
Member

This repo is moved to central Azure SDK repo. Can you please create PR there?

https://github.com/Azure/azure-sdk-for-net/tree/master/sdk/eventhub

@vishwas-neo
Copy link
Author

This repo is moved to central Azure SDK repo. Can you please create PR there?

https://github.com/Azure/azure-sdk-for-net/tree/master/sdk/eventhub
Hi,
Please find the PR below
Azure/azure-sdk-for-net#6523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants