Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pipelines][create] Add partial support for github enterprise #1247

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

amrmahdi
Copy link

@amrmahdi amrmahdi commented Feb 1, 2022

This change add partial for support for creating pipelines for github enterprise repos.

It is partial because it only supports creating pipelines with existing yaml files, requiring --yaml-path.

Partially addresses #620

Please make sure the code is following contribution guidelines in CONTRIBUTING.md

  • : This PR has a corresponding issue open in the Repository.
  • : Approach is signed off on the issue.

This change add partial for support for creating pipelines for github enterprise repos.

It is partial because it only supports creating pipelines with existing yaml files, requiring  `--yaml-path`.

Partially addresses Azure#620
@amrmahdi amrmahdi requested a review from aasiddiq February 1, 2022 18:09
@amrmahdi
Copy link
Author

amrmahdi commented Feb 2, 2022

@aasiddiq Thanks for the review. Would you be able to merge the changes? And once it is merged, when you expect for this change to be officially released?

@AustinSmart
Copy link

Any chance this can be merged and released?

Copy link

@makaras makaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@splusq @aasiddiq what is the reason that change is not merged and released yet?

@coolhome
Copy link

coolhome commented Dec 12, 2022

I imagine this was not merged because it is currently not supported.

{
	"$id": "1",
	"innerException": null,
	"message": "This API does not support creating pipelines with repositories of type GitHubEnterprise.",
	"typeName": "Microsoft.Azure.Pipelines.WebApi.UnsupportedRepositoryTypeException, Microsoft.Azure.Pipelines.WebApi",
	"typeKey": "UnsupportedRepositoryTypeException",
	"errorCode": 0,
	"eventId": 3000
}

What an undocumented disappointment this has been.

UPDATE - I was able to implement the PR changes to my local install and it actually worked. The only hiccup I ran into was not knowing the service connection id (guid) instead of the name of the connection. What is preventing this from being released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants