-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pipelines][create] Add partial support for github enterprise #1247
base: master
Are you sure you want to change the base?
Conversation
This change add partial for support for creating pipelines for github enterprise repos. It is partial because it only supports creating pipelines with existing yaml files, requiring `--yaml-path`. Partially addresses Azure#620
@aasiddiq Thanks for the review. Would you be able to merge the changes? And once it is merged, when you expect for this change to be officially released? |
Any chance this can be merged and released? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine this was not merged because it is currently not supported. {
"$id": "1",
"innerException": null,
"message": "This API does not support creating pipelines with repositories of type GitHubEnterprise.",
"typeName": "Microsoft.Azure.Pipelines.WebApi.UnsupportedRepositoryTypeException, Microsoft.Azure.Pipelines.WebApi",
"typeKey": "UnsupportedRepositoryTypeException",
"errorCode": 0,
"eventId": 3000
} What an undocumented disappointment this has been. UPDATE - I was able to implement the PR changes to my local install and it actually worked. The only hiccup I ran into was not knowing the service connection id (guid) instead of the name of the connection. What is preventing this from being released? |
This change add partial for support for creating pipelines for github enterprise repos.
It is partial because it only supports creating pipelines with existing yaml files, requiring
--yaml-path
.Partially addresses #620
Please make sure the code is following contribution guidelines in CONTRIBUTING.md