-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ado with oidc #3924
ado with oidc #3924
Conversation
fix - start pipeline for branchName
@vhvb1989 Trying to understand how we're modeling service connection in this model. Usually in az, a user needs to specify a service connection explicitly. If we're hiding the concept of a service connection, what is this service connection tied to? What is the gesture to create a new one vs. reuse one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall - adds some feedback that I'd like to see resolved before merging.
Sadly, our initial design to support setting up pipelines for Azdo was all about building and having something similar to GitHub, instead of going 100% idiomatic to the Aure DevOps World. That been said, the concept of a service connection is currently hidden, as you mentioned, in azd. |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIDocumentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, some small NITs and comments but nothing blocking. Thanks for making easy for folks to adopt OIDC in their AzDo pipelines!
fix: #2777
Updating azd pipeline config to support Federated Credential for Azure DevOps
The azdo provider's order of configuration was updated to depend on the
auth-type
like:federated
endpointScheme := "WorkloadIdentityFederation"
Issuer
andSubject
from it to create the federated credential for the SP.client-credentials
endpointScheme = "ServicePrincipal"
Manual tests
For each test, use a new fresh azd project which has not local git project. For example, run:
Then, make sure there is a

.azdo/pipelines
folder on the root of the project with aazure-dev.yml
:Here is a sample for the pipeline definition for the sample app:
base tests
Migration test
Regression test
Repeat all test above using github as provider