-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swa: ability to use swa-cli.config.json #3553
Conversation
Changes Explanation: Instead of utilizing the |
@ankur198 , thank you for your contribution. Your initial changes were not enough because azd was not using the If there is not a |
/azp run azure-dev - cli |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-dev - cli |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-dev - repoman |
Azure Pipelines successfully started running 1 pipeline(s). |
Repoman Generation ResultsRepoman pushed changes to remotes for the following projects: Project: todo-csharp-cosmos-sqlRemote: azure-samples-stagingBranch: pr/3553You can initialize this project with: azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/3553 View Changes | Compare Changes Project: todo-csharp-sql-swa-funcRemote: azure-samples-stagingBranch: pr/3553You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/3553 View Changes | Compare Changes Project: todo-csharp-sqlRemote: azure-samples-stagingBranch: pr/3553You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql -b pr/3553 View Changes | Compare Changes Project: todo-java-mongo-acaRemote: azure-samples-stagingBranch: pr/3553You can initialize this project with: azd init -t Azure-Samples/todo-java-mongo-aca -b pr/3553 View Changes | Compare Changes Project: todo-java-mongoRemote: azure-samples-stagingBranch: pr/3553You can initialize this project with: azd init -t Azure-Samples/todo-java-mongo -b pr/3553 View Changes | Compare Changes Project: todo-java-postgresql-terraformRemote: azure-samples-stagingBranch: pr/3553You can initialize this project with: azd init -t Azure-Samples/todo-java-postgresql-terraform -b pr/3553 View Changes | Compare Changes Project: todo-nodejs-mongo-acaRemote: azure-samples-stagingBranch: pr/3553You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/3553 View Changes | Compare Changes Project: todo-nodejs-mongo-aksRemote: azure-samples-stagingBranch: pr/3553You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/3553 View Changes | Compare Changes Project: todo-nodejs-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/3553You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/3553 View Changes | Compare Changes Project: todo-nodejs-mongoRemote: azure-samples-stagingBranch: pr/3553You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo -b pr/3553 View Changes | Compare Changes Project: todo-nodejs-mongo-terraformRemote: azure-samples-stagingBranch: pr/3553You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-terraform -b pr/3553 View Changes | Compare Changes Project: todo-python-mongo-acaRemote: azure-samples-stagingBranch: pr/3553You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-aca -b pr/3553 View Changes | Compare Changes Project: todo-python-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/3553You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/3553 View Changes | Compare Changes Project: todo-python-mongoRemote: azure-samples-stagingBranch: pr/3553You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo -b pr/3553 View Changes | Compare Changes Project: todo-python-mongo-terraformRemote: azure-samples-stagingBranch: pr/3553You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-terraform -b pr/3553 View Changes | Compare Changes |
/azp run azure-dev - cli |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-dev - cli |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-dev - cli |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-dev - cli |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small questions but overall looks good. It does feel like the logic here is a little convoluted, because our framework_service and framework_target abstractions split the build/deploy process into parts and these external tools like swa want to push stuff back together.
I think this is as clean as we can get it (and it follows a similar model to what I was playing around when trying to use dotnet
to build and push container images) - but we probably need to start thinking in the team about if the primitives here are right or they are forcing us to build things in an unnatural way.
Really great work here, @ankur198, thanks for helping improve azd
!
/azp run azure-dev - cli |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIDocumentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When deploying SWA using
azd
lacked the ability to configure complex build commands.swa
cli natively utilisesswa-cli.config.json
along with flags.Changes on this PR allows
azd
to detect theswa-cli.config.json
. If not present, then use the default behavior ofswa
cli.IMO this is much better trade off than lacking ability to setup swa options.
Linked issue: #1953 #1759
fix: #1953