Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity #159

Merged
merged 40 commits into from
Mar 8, 2024
Merged

Unity #159

merged 40 commits into from
Mar 8, 2024

Conversation

skarpecki
Copy link
Contributor

I've started working on Unity Catalog API. I feel like doing it in parts with Draft PR makes most sense, as it will be a lot of code in the end. I will simply push changes in chunks. There are also changes from Pipelines PR on this branch, so until the other branch is merged we'll have some already reviewed changes here.

@memoryz memoryz added this to the 2.3 milestone Oct 29, 2023
@skarpecki
Copy link
Contributor Author

@memoryz - how many actions do we need in SampleProgram? At least one for each endpoint will be sufficient?

@skarpecki skarpecki marked this pull request as ready for review November 7, 2023 15:57
@skarpecki
Copy link
Contributor Author

Also, I added lineage endpoint which is mentioned here - https://learn.microsoft.com/en-us/azure/databricks/data-governance/unity-catalog/data-lineage . It is not covered with tests and not added in SampleProgram as it cannot be found in REST API documentation, however I will need that endpoint for my project.

@memoryz memoryz self-requested a review November 11, 2023 21:11
@memoryz
Copy link
Contributor

memoryz commented Nov 14, 2023

@skarpecki let me know when this is ready for code review. :)

@skarpecki
Copy link
Contributor Author

@memoryz - i'm pretty busy right now. Most of the code is good to go. I'm just wondering if should I add some more sample methods, although I feel like it can be done in future PR.

@memoryz memoryz added the enhancement New feature or request label Mar 8, 2024
@memoryz memoryz merged commit 7928b2e into Azure:master Mar 8, 2024
4 of 5 checks passed
@skarpecki
Copy link
Contributor Author

@memoryz - thank you for fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants