-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhacement of outputs #64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nachoalonsoportillo
commented
Feb 6, 2023
- Enhance outputs.
- Disable HDInsight PR-based triggers.
- Add some additional validations.
- Make Terratest tests check all output variables.
…tional validations. Made Terratest tests check all output variables.
murggu
requested changes
Feb 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nachoalonsoportillo some modules are failing:
output issues
- resource group: check the output, it should be 'name'
- event hub and event hub namespace: review the outputs
time out errors
- increase time out for github actions for cosmos mongo db, and cosmos table
- increase time out for github actions for synapse spark and synapse sql pool
others
- log analytics cluster: seems that we've reached some quota on the region. Try to change the region so we can get the test green
- psql module: seems that the test is getting 403. I tried to remove the state file and rerun the test
murggu
approved these changes
Feb 7, 2023
fix #67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.