Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhacement of outputs #64

Merged
merged 11 commits into from
Feb 7, 2023
Merged

Enhacement of outputs #64

merged 11 commits into from
Feb 7, 2023

Conversation

nachoalonsoportillo
Copy link
Contributor

  • Enhance outputs.
  • Disable HDInsight PR-based triggers.
  • Add some additional validations.
  • Make Terratest tests check all output variables.

@murggu murggu self-requested a review February 7, 2023 10:20
Copy link
Contributor

@murggu murggu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nachoalonsoportillo some modules are failing:

output issues

  • resource group: check the output, it should be 'name'
  • event hub and event hub namespace: review the outputs

time out errors

  • increase time out for github actions for cosmos mongo db, and cosmos table
  • increase time out for github actions for synapse spark and synapse sql pool

others

  • log analytics cluster: seems that we've reached some quota on the region. Try to change the region so we can get the test green
  • psql module: seems that the test is getting 403. I tried to remove the state file and rerun the test

@murggu murggu merged commit 927d221 into main Feb 7, 2023
@nachoalonsoportillo nachoalonsoportillo deleted the improvement/enhance-outputs branch February 7, 2023 18:14
@nachoalonsoportillo
Copy link
Contributor Author

fix #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants