Add responseHeaders errors #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update readme.md to be more non-node expert friendly Fix typo in test.js Add/Merge responseHeaders to error before calling defer.reject in all wrapped calls. This allows upstream caller to inspect Headers in order to potentially determine source of the error.
|
Hi @BillAtPros, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, AZPRBOT; |
Closed
shipunyc
added a commit
to shipunyc/azure-documentdb-node
that referenced
this pull request
Jun 3, 2015
…ew additional typos.
shipunyc
added a commit
that referenced
this pull request
Jun 3, 2015
Re-applies change: Add responseHeaders errors #46, and fixes a few ad…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code adds the responseHeaders to the error passed to defferred.reject when a call fails. This provides additional insight into the failure by exposing the response headers and allows handling cases like 429 codes where additional info (the retry time) is contained in the response headers.
big assist from @shpros
small additional cleanup
Update readme.md to be more non-node expert friendly
Fix typo in test.js
Add/Merge responseHeaders to error before calling defer.reject in all wrapped calls.
This allows upstream caller to inspect Headers in order to potentially determine source of the error.
Add test case.