-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a linting task to the project so contributions follow the same standard #40
Comments
@aliuy I think I'll submit a PR with the basic setup with the rules I currently have in my projects and then you can tweak the options to follow your style guide if that sounds ok. |
That sounds great! I'm a bit new to ESLint and JSCS (I've mostly used JSHint for my projects). Mind giving me a little background knowledge? On the surface, it looks like ESLint also supports rules for styling. Is there an advantage for using both? |
I think the plan for ESLint is to have the same rules as JSCS but when I started they weren't implemented yet so I right now I'm using JSCS to validate all my spacing is the right one and the other to make sure I have consistent returns, no shadow variables, etc. Haven't check recently if they have added all the style rules. |
Now that http://dev.modern.ie is released I have some time to work on this. I'll probably do a PR this week if you are still interested :) |
Yes, we'd love that! 👍 |
Thanks. |
I normally use ESLint for code quality, JSCS for code style (spaces, etc.) as a grunt-tasks during the build process and then an .editorconfig file so my editor automatically picks if I should be using tabs or spaces, how many, etc.
We could probably add a test task to the gruntfile to use the code you already have.
The text was updated successfully, but these errors were encountered: