-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Change Feed Processor code migration sample #782
Conversation
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Can the 'new CFP' emit a message when a range is assigned / unassigned? (Yes, I'm attempting to once again draw attention to #400 :P) (As a workaround, does the v3 lib still use Liblog so I can at least echo such status changes to the console) ? |
We are actually discussing that this week. I can add Traces you can hook to as a Diagnostics Source here: https://github.com/Azure/azure-cosmos-dotnet-v3/blob/master/Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/FeedProcessing/ChangeFeedObserverBase.cs#L23 |
I believe that would be a very important feature (also the assignment side is equally interesting to be able to log timings of etc) A useful thing in the context of this PR might also be to log when batches are obtained in the new API (or am I missing it?) This does bring me to a second set of requirements in this space, which are covered in #616:
(I know this is quite the tangent for a PR discussion; I believe the two cited issues sum up the concerns and needs, but am happy to expand on them and/or consolidate them if desired) |
I added a comment to #400 (comment) summarizing the bulk of these tangential concerns, which might represent a better place to discuss such things. As noted earlier, the basic logging hooks probably make sense to consider in the context of this particular PR (though manual checkpointing support #616 might inform the API design) |
Pull Request Template
Description
Adding a sample to cover code migration from the Change Feed Processor library (SDK V2) to V3 SDK.