Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] fix: [Linux] [NPM] handle #2977 for netpols without cidr #3006

Merged
merged 1 commit into from
Sep 12, 2024
Merged

[backport] fix: [Linux] [NPM] handle #2977 for netpols without cidr #3006

merged 1 commit into from
Sep 12, 2024

Conversation

huntergregory
Copy link
Contributor

Reason for Change:
Backport #2990

Issue Fixed:
Fixes #2977 completely in release/v1.5 branch

Requirements:

@huntergregory
[backport] fix: [Linux] [NPM] handle #2977 for netpols without cidrs (#…
281abbf 
…2990)

* fix: [Linux] [NPM] handle #2977 for netpols without cidrs

Signed-off-by: Hunter Gregory <[email protected]>

* fix: lock and no need to track policy key

Signed-off-by: Hunter Gregory <[email protected]>

* style: remove dead code

Signed-off-by: Hunter Gregory <[email protected]>

---------

Signed-off-by: Hunter Gregory <[email protected]>
@huntergregory huntergregory added npm Related to NPM. linux labels Sep 11, 2024
@huntergregory huntergregory requested review from a team as code owners September 11, 2024 22:32
@huntergregory
Copy link
Contributor Author

/azp run Azure Container Networking PR

@huntergregory
Copy link
Contributor Author

/azp run NPM Conformance Tests

@huntergregory
Copy link
Contributor Author

/azp run NPM Scale Test

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@huntergregory
Copy link
Contributor Author

scale test flaked:

Error from server: error dialing backend: EOF
[2024-09-11 23:12:10+00:00] WARNING: expected scale Pod real-agnhost-dep-00004-5b4b779894-p9tld to be able to connect to scale Pod real-agnhost-dep-00005-cb9c44c89-5br7p
[2024-09-11 23:12:10+00:00] ERROR: initial connectivity test timed out. Last try was about 259 seconds after pinger Pods began running

@huntergregory
Copy link
Contributor Author

Scale test passed here: https://msazure.visualstudio.com/One/_build/results?buildId=102998153&view=results

The "Rerun" option is broken for the scale test pipeline.

@huntergregory huntergregory added this pull request to the merge queue Sep 12, 2024
Merged via the queue into release/v1.5 with commit 654fad3 Sep 12, 2024
18 of 20 checks passed
@huntergregory huntergregory deleted the huntergregory/backport-2990 branch September 12, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayaisaiah rayaisaiah rayaisaiah approved these changes

@matmerr matmerr Awaiting requested review from matmerr matmerr is a code owner automatically assigned from Azure/acn-npm-reviewers

Assignees
No one assigned
Labels
linux npm Related to NPM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huntergregory @rayaisaiah