ci: remove logger field from portforwarder to avoid race with goroutine #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QxBytes
added
cni
ramiro-gamarra
previously approved these changes
Aug 27, 2024
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
…ne (#2959) do not pass testing logger into goroutine to avoid race
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ramiro-gamarra
approved these changes
Aug 29, 2024
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
QxBytes
added a commit
that referenced
this pull request
Aug 29, 2024
…ne (#2959) * do not pass testing logger into goroutine to avoid race * fix port forwarder
Merged
4 tasks
QxBytes
added a commit
that referenced
this pull request
Dec 12, 2024
…ne (#2959) * do not pass testing logger into goroutine to avoid race * fix port forwarder
Merged
4 tasks
QxBytes
added a commit
that referenced
this pull request
Dec 12, 2024
…ne (#2959) * do not pass testing logger into goroutine to avoid race * fix port forwarder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
When running pipelines, we pass the testing object into the port forwarder struct. Then, we spawn a go routine and from within it, call the test's logger. This causes a data race in the unit tests, which causes various scenarios to flake. The testing logger is not thread safe and should not be called from within a go routine. Instead, this PR modifies these log statements to use the "log" package, which is thread safe, to log messages from the port forwarding file.
Issue Fixed:
Requirements:
Notes:
Ran the cni release pipeline (where this issue was detected) three times, and the data race error has not shown up. Even during failure, it is not a data race, and the error logs do print: example