Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding/Remove static arp entry for pod IP in VM #273

Merged
merged 3 commits into from
Dec 11, 2018
Merged

Conversation

tamilmani1989
Copy link
Member

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
This PR fixes the issues where sometimes packet is getting routed to host instead of pod. Setting static arp entry will prevent vm getting arp responses from host

Special notes for your reviewer:

Release note:

@tamilmani1989 tamilmani1989 changed the title Adding/Remove static arp entry for pod in VM Adding/Remove static arp entry for pod IP in VM Dec 11, 2018
netlink/link.go Outdated Show resolved Hide resolved
Copy link
Contributor

@sharmasushant sharmasushant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s not do this in hairpin mode. Also, let’s not fail add call if we can’t add arp (just log it).

@sharmasushant sharmasushant merged commit a1b4da1 into master Dec 11, 2018
@saiyan86 saiyan86 deleted the saticarp branch May 28, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants