fix: close connection on any return from azure-vnet-telemetry #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QxBytes
force-pushed
the
alew/closeonerror
branch
from
cec3263 to
e8447f9
Compare
tamilmani1989
previously approved these changes
Apr 29, 2024
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This reverts commit e8447f9.
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tamilmani1989
approved these changes
Apr 29, 2024
QxBytes
added a commit
that referenced
this pull request
Apr 30, 2024
* move error handling code to defer * invert conditional * address linter issues * add close connection on telemetry unmarshal error unit test * Revert "add close connection on telemetry unmarshal error unit test" This reverts commit e8447f9.
QxBytes
added a commit
that referenced
this pull request
May 1, 2024
…ry (#2711) (#2719) fix: close connection on any return from azure-vnet-telemetry (#2711) * move error handling code to defer * invert conditional * address linter issues * add close connection on telemetry unmarshal error unit test * Revert "add close connection on telemetry unmarshal error unit test" This reverts commit e8447f9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Prevents leaking of sockets when azure-vnet-telemetry errors and fails to unmarshal mentioned in #2703 (this pr does not fix the unmarshaling error itself)
Requirements:
Notes:
The unit test uses time.sleep to ensure the connection populates in the server, and we will be rewriting these tests later anyway with stateless cni.