fix: Pipeline agent image update from 18.04 to 22.04 | AzSecPack #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpayne3506
changed the title
jpayne3506
changed the title
jpayne3506
force-pushed
the
jpayne3506/update-network-linux-test
branch
from
ab02fd2 to
54fb0b3
Compare
estebancams
previously approved these changes
Oct 26, 2023
|
Will integrate changes from #1985 which #2320 (comment) mentions in the matching closed PR in a future PR to fix the |
4 tasks
sheylatrudo
approved these changes
Oct 26, 2023
| @@ -499,7 +499,7 @@ manifest-push: # util target to push multiarch container manifest. | |||
| $(CONTAINER_BUILDER) manifest push --all $(IMAGE_REGISTRY)/$(IMAGE):$(TAG) docker://$(IMAGE_REGISTRY)/$(IMAGE):$(TAG) | |||
|
|
|||
| manifest-skopeo-archive: # util target to export tar archive of multiarch container manifest. | |||
| skopeo copy --all docker://$(IMAGE_REGISTRY)/$(IMAGE):$(TAG) oci-archive:$(IMAGE_ARCHIVE_DIR)/$(IMAGE)-$(TAG).tar | |||
| skopeo copy --all docker://$(IMAGE_REGISTRY)/$(IMAGE):$(TAG) oci-archive:$(IMAGE_ARCHIVE_DIR)/$(IMAGE)-$(TAG).tar --debug | |||
There was a problem hiding this comment.
Do we want to keep this as debug?
There was a problem hiding this comment.
I believe we should as it provides good understanding of what is happening with the *auth.json files IRT skopeo. Future changes to skopeo could break the current hack and future CI changes of this command.
sheylatrudo
reviewed
Oct 26, 2023
|
|
||
| echo "setting XDG_RUNTIME_DIR" | ||
| export XDG_RUNTIME_DIR=/run/user/$(id -u) | ||
| echo $XDG_RUNTIME_DIR |
There was a problem hiding this comment.
Do we want to set this in the task or set this as an env var from the pipeline level?
There was a problem hiding this comment.
If we set this as an env var in the pipeline then it impacts podman and buildah negatively. This hack is exclusive to skopeo.
paulyufan2
approved these changes
Oct 26, 2023
jpayne3506
added
fix
rbtr
approved these changes
Oct 26, 2023
jpayne3506
added a commit
that referenced
this pull request
Nov 3, 2023
* Use ResolveCtl for Ubuntu22.04 * test: debug * test: XDG dir * ci: Remove sudo for testvalidate * ci: remove sudo dualstack * ci: remove test scripts * fix: lint --------- Co-authored-by: Sheyla Trudo <[email protected]>
rbtr
pushed a commit
that referenced
this pull request
Nov 3, 2023
…#2327) to release/v1.4 (#2353) fix: Pipeline agent image update from 18.04 to 22.04 | AzSecPack (#2327) * Use ResolveCtl for Ubuntu22.04 * test: debug * test: XDG dir * ci: Remove sudo for testvalidate * ci: remove sudo dualstack * ci: remove test scripts * fix: lint --------- Co-authored-by: Sheyla Trudo <[email protected]>
rbtr
removed
the
needs-backport
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR is the first to migrate our agent pool to a 1ES maintained agent pool. This is primarily to unblock the ACN PR pipeline and will be improved upon.
Future CI:
sudowhere applicableIssue Fixed:
Requirements:
Notes: