Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ClusterSubnetState JSON annotations and kubectl printcolumns #1591

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Fix ClusterSubnetState JSON annotations and kubectl printcolumns #1591

merged 1 commit into from
Sep 12, 2022

Conversation

rbtr
Copy link
Contributor

@rbtr rbtr commented Sep 9, 2022 •
edited
Loading

Evan Baker [email protected]

Reason for Change:

  • Updates the JSON annotations to be lowercase for consistency with the rest of Kubernetes
  • Fixes the printercolumns to refer to real fields so that we get values in the kubectl output

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr requested a review from rsagasthya September 9, 2022 00:02
@rbtr rbtr self-assigned this Sep 9, 2022
@rbtr rbtr added cns Related to CNS. swift Related to SWIFT networking. fix Fixes something. labels Sep 9, 2022
@rbtr rbtr requested a review from thatmattlong September 9, 2022 00:08
@rbtr rbtr mentioned this pull request Sep 12, 2022
Closed
@rbtr rbtr changed the title fix clustersubnetstate annotations and printercols Fix clustersubnetstate JSON annotations and kubectl printercolumns Sep 12, 2022
@rbtr rbtr changed the title Fix clustersubnetstate JSON annotations and kubectl printercolumns Fix ClusterSubnetState JSON annotations and kubectl printercolumns Sep 12, 2022
@rbtr rbtr changed the title Fix ClusterSubnetState JSON annotations and kubectl printercolumns Fix ClusterSubnetState JSON annotations and kubectl printcolumns Sep 12, 2022
@rbtr rbtr merged commit 6dc1dbb into Azure:master Sep 12, 2022
@rbtr rbtr deleted the fix/clustersubnetstate-casing branch September 12, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsagasthya rsagasthya rsagasthya approved these changes

@thatmattlong thatmattlong Awaiting requested review from thatmattlong

Assignees

@rbtr rbtr

Labels
cns Related to CNS. fix Fixes something. swift Related to SWIFT networking.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbtr @rsagasthya