Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin wheel version. #8896

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Pin wheel version. #8896

merged 1 commit into from
Mar 29, 2019

Conversation

tjprescott
Copy link
Member

CLI extensions rely on wheel files containing metadata and thus require they be built using wheel 0.29.0 or 0.30.0. Recent releases are not compatible and updating the CLI results in wheel 0.31.1. This PR pins the version.


This checklist is used to make sure that common guidelines for a pull request are followed.

  • [N/A] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

@tjprescott tjprescott added the Core CLI core infrastructure label Mar 27, 2019
@tjprescott tjprescott added this to the Sprint 58 milestone Mar 27, 2019
@yugangw-msft
Copy link
Contributor

yugangw-msft commented Mar 29, 2019

I assume this won't impact the original homebrew fix which unpinned the version

@tjprescott
Copy link
Member Author

tjprescott commented Mar 29, 2019

#8744
@marstr for comment. The reason for pinning to 0.30.0 was not solely due to the WHEEL_INFO_RE. It is more fundamentally to do with pypa/wheel#195 which is called out in the error message you will receive if your extension is built with anything other than 0.29.0 or 0.30.0.

Right now, the unpinning of this is giving extension developers a version of wheel that the CI will reject and also broke the extension docs CI. I think we should revert this change until we see how much work is involved in making our entire extensions infrastructure compatible with the latest versions of wheel before we alter this dependency requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core CLI core infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants