Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix positional argument validation #6189

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Fix positional argument validation #6189

merged 1 commit into from
Apr 24, 2018

Conversation

tjprescott
Copy link
Member

Fixes #6187.

Also, prevents using options_list=[] for the argument method and ensures that the unrecognized kwarg TypeError is thrown when an unsupported kwarg is used with positional.


This checklist is used to make sure that common guidelines for a pull request are followed.

  • [N/A] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

@tjprescott tjprescott added bug This issue requires a change to an existing behavior in the product in order to be resolved. Infrastructure labels Apr 23, 2018
@tjprescott tjprescott added this to the Sprint 36 (Build) milestone Apr 23, 2018
@tjprescott tjprescott requested a review from williexu April 23, 2018 22:00
@promptws
Copy link

View a preview at https://prompt.ws/r/Azure/azure-cli/6189
This is an experimental preview for @microsoft users.

@williexu williexu merged commit e6a56f7 into Azure:dev Apr 24, 2018
@tjprescott tjprescott deleted the FixPositional branch April 25, 2018 05:03
@haroldrandom haroldrandom added bug This issue requires a change to an existing behavior in the product in order to be resolved. Infrastructure labels Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registering positional argument fails when a previous argument being registered has no "options_list"
4 participants