[Network] Improve NSG rule table output format #6184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View a preview at https://prompt.ws/r/Azure/azure-cli/6184 |
tjprescott
changed the title
yugangw-msft
approved these changes
Apr 23, 2018
| item['Priority'] = result['priority'] | ||
| item['SourcePortRanges'] = result['sourcePortRange'] or ' '.join(result['sourcePortRanges']) | ||
| item['SourceAddressPrefixes'] = result['sourceAddressPrefix'] or ' '.join(result['sourceAddressPrefixes']) | ||
| item['SourceASG'] = result['sourceApplicationSecurityGroups'] or 'None' |
There was a problem hiding this comment.
I assume returning a string 'None' is the pattern for output, instead of a plain None to be serialized as null eventually
There was a problem hiding this comment.
I think i got it now, that using the string 'None' would preventing the column from missing if the value is None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6031.
Also closes ICM ticket:
https://icm.ad.msft.net/imp/v3/incidents/details/65053548/home
This checklist is used to make sure that common guidelines for a pull request are followed.
[N/A] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.